Skip to content

Build MBQL from Python objects#32

Merged
chasleslr merged 16 commits into
developfrom
feature/aggregation
Feb 25, 2022
Merged

Build MBQL from Python objects#32
chasleslr merged 16 commits into
developfrom
feature/aggregation

Conversation

@chasleslr
Copy link
Copy Markdown
Owner

No description provided.

Charles Larivier added 4 commits February 24, 2022 00:20
Signed-off-by: Charles Larivier <charles@dribbble.com>
Signed-off-by: Charles Larivier <charles@dribbble.com>
Signed-off-by: Charles Larivier <charles@dribbble.com>
Signed-off-by: Charles Larivier <charles@dribbble.com>
@chasleslr chasleslr force-pushed the feature/aggregation branch 2 times, most recently from b847867 to f1eb888 Compare February 24, 2022 05:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2022

Codecov Report

Merging #32 (7fafd8b) into develop (dac395f) will increase coverage by 0.02%.
The diff coverage is 98.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #32      +/-   ##
===========================================
+ Coverage    98.47%   98.50%   +0.02%     
===========================================
  Files           29       39      +10     
  Lines         1181     1467     +286     
===========================================
+ Hits          1163     1445     +282     
- Misses          18       22       +4     
Impacted Files Coverage Δ
src/metabase/mbql/filter.py 95.00% <95.00%> (ø)
src/metabase/__init__.py 100.00% <100.00%> (ø)
src/metabase/mbql/aggregations.py 100.00% <100.00%> (ø)
src/metabase/mbql/base.py 100.00% <100.00%> (ø)
src/metabase/mbql/groupby.py 100.00% <100.00%> (ø)
src/metabase/mbql/query.py 100.00% <100.00%> (ø)
src/metabase/resource.py 96.15% <100.00%> (ø)
src/metabase/resources/metric.py 100.00% <100.00%> (ø)
tests/helpers.py 100.00% <100.00%> (ø)
tests/mbql/test_aggregations.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0d00a...7fafd8b. Read the comment docs.

Charles Larivier added 12 commits February 24, 2022 20:26
Signed-off-by: Charles Larivier <charles@dribbble.com>
Signed-off-by: Charles Larivier <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
Signed-off-by: Charles Lariviere <charles@dribbble.com>
@chasleslr chasleslr merged commit 9d20578 into develop Feb 25, 2022
@chasleslr chasleslr deleted the feature/aggregation branch February 25, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for using Metric in Query aggregations Add support for name in Aggregation

1 participant